Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core Image Reference Asset #197

Merged
merged 17 commits into from
Nov 8, 2023

Conversation

aarianasingh
Copy link
Contributor

Fixes #186
Created an Image reference asset (core and React).

Change Type (required)

Indicate the type of change your pull request is:

  • patch
  • minor
  • major

@aarianasingh aarianasingh marked this pull request as draft October 20, 2023 14:36
@aarianasingh aarianasingh marked this pull request as ready for review October 20, 2023 14:55
Copy link
Contributor

@hborawski hborawski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the lint is failing, you should be able to run:

bazel test //plugins/reference-assets/core:@player-ui/reference-assets-plugin-lint

to reproduce

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (5faba6b) 82.25% compared to head (c3207f0) 82.18%.
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #197      +/-   ##
==========================================
- Coverage   82.25%   82.18%   -0.08%     
==========================================
  Files         130      132       +2     
  Lines        4526     4540      +14     
  Branches     1114     1117       +3     
==========================================
+ Hits         3723     3731       +8     
- Misses        526      531       +5     
- Partials      277      278       +1     
Files Coverage Δ
plugins/reference-assets/core/src/plugin.ts 0.00% <ø> (ø)
plugins/reference-assets/react/src/plugin.tsx 81.81% <ø> (ø)
...eference-assets/core/src/assets/image/transform.ts 77.77% <77.77%> (ø)
.../reference-assets/react/src/assets/image/Image.tsx 20.00% <20.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hborawski hborawski added the minor Increment the minor version when merged label Oct 30, 2023
@mercillo mercillo merged commit a07482d into player-ui:main Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest minor Increment the minor version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Core: New Reference Asset - Image
3 participants