Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add diagrams to content section #198

Closed

Conversation

mehrsharma
Copy link

@mehrsharma mehrsharma commented Oct 20, 2023

Adding diagrams to docs

Change Type (required)

Indicate the type of change your pull request is:

  • patch
  • minor
  • major

@KetanReddy KetanReddy added patch Increment the patch version when merged skip-release Preserve the current version when merged labels Oct 20, 2023
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is talking about how flows are processed, instead of Node # could you use something like NavigationFlowState to tie it back to the types.

@KetanReddy
Copy link
Member

Hey @mehrsharma! Thanks for the PR. Going to make this a patch release and mark it as skip-release since its only documentation updates. I have one minor point of feedback on one of the diagrams but it looks good!

@mehrsharma mehrsharma requested a review from KetanReddy October 30, 2023 15:34
@mercillo mercillo closed this Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged skip-release Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants