Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel - added rules player back for docs site #470

Merged
merged 12 commits into from
Aug 2, 2024
Merged

Conversation

mercillo
Copy link
Contributor

@mercillo mercillo commented Aug 1, 2024

This adds back in the stamp rule and gh_deploy from rules_player. Allowing us to publish docs

Change Type (required)

Indicate the type of change your pull request is:

  • patch
  • minor
  • major

Does your PR have any documentation updates?

  • Updated docs
  • No Update needed
  • Unable to update docs

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 97.25490% with 14 lines in your changes missing coverage. Please review.

Project coverage is 91.94%. Comparing base (98764a6) to head (a8a147d).
Report is 33 commits behind head on main.

Files Patch % Lines
core/player/src/view/plugins/applicability.ts 92.30% 3 Missing ⚠️
core/player/src/view/plugins/asset.ts 92.85% 3 Missing ⚠️
core/player/src/view/plugins/multi-node.ts 97.26% 2 Missing ⚠️
core/player/src/view/plugins/switch.ts 97.53% 1 Missing and 1 partial ⚠️
core/player/src/view/plugins/template.ts 94.73% 2 Missing ⚠️
plugins/async-node/core/src/index.ts 98.01% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #470      +/-   ##
==========================================
+ Coverage   91.75%   91.94%   +0.19%     
==========================================
  Files         339      340       +1     
  Lines       27044    26838     -206     
  Branches     1963     1946      -17     
==========================================
- Hits        24814    24677     -137     
+ Misses       2216     2147      -69     
  Partials       14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mercillo mercillo marked this pull request as ready for review August 2, 2024 15:32
docs/BUILD Outdated Show resolved Hide resolved
tsconfig.json Outdated
@@ -22,7 +22,5 @@
"resolveJsonModule": true,
"composite": true,
"lib": ["DOM", "ES2020"],
"isolatedDeclarations": true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did these change?

@KetanReddy KetanReddy merged commit 1d32a97 into main Aug 2, 2024
11 checks passed
@KetanReddy KetanReddy deleted the bazel/docsSite branch August 2, 2024 18:39
This was referenced Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants