-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs refresh with Astro #506
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #506 +/- ##
==========================================
- Coverage 91.92% 91.88% -0.05%
==========================================
Files 341 341
Lines 27290 27303 +13
Branches 1944 1944
==========================================
Hits 25087 25087
- Misses 2189 2202 +13
Partials 14 14 ☔ View full report in Codecov by Sentry. |
We might want to redo the PlatformTabs component to use the Starlight |
The only downside was not persisting that to the URL for sharing (not sure if that's a big deal or not) |
* Preview component breaking * Update tailwind configs for reference assets to use player- namespace * Fix preview end state and column styling --------- Co-authored-by: Adam Dierkens <Adam_Dierkens@intuit.com>
From whats left, I think we can defer styling and most content updates to post rollout tasks just so we can get this new version out. Only requirement left is probably the version selector and verifying stamping and mobile which I don't think we can really do until we put it out at least on next |
c9500a3
Updating our docs site to use astro.
TODO
Version
Published prerelease version:
0.10.0-next.1
Changelog
Release Notes
ios: enhance tapable logger to handle variadic args from the JS log (#524)
Prefixing message with the format
[Player] [\(logLevel)]:
moved out of the Tapable logger and moved to PrintLoggerPlugin. Any consumers using their own LoggerPlugin will need to append the logLevel if they want to print itBefore
After
Breaking Changes
Any usage of the
player.logger.hooks
taps will have breaking changes in the callback because the calls have been changed to provide a[Any]
type instead ofString
so it can be returned in the form of messages instead of a single message. Unless nothing is done in the callback to access the value but just to print it, there should be breaking changesExample:
🚀 Enhancement
🐛 Bug Fix
🏠 Internal
📝 Documentation
Authors: 4