Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1297 load session store using Play.classloader #1311

Merged
merged 1 commit into from
Nov 29, 2019
Merged

#1297 load session store using Play.classloader #1311

merged 1 commit into from
Nov 29, 2019

Conversation

asolntsev
Copy link
Contributor

otherwise Class.forName uses Injector's classloader which doesn't contain user provided classes.

Pull Request Checklist

Fixes

Fixes #1297

@asolntsev
playframework#1297 load session store using Play.classloader
29ba917 
otherwise `Class.forName` uses Injector's classloader which doesn't contain user provided classes.
@asolntsev asolntsev self-assigned this Jul 23, 2019
@asolntsev asolntsev mentioned this pull request Jul 23, 2019
Closed
@xael-fry xael-fry merged commit 516a31d into playframework:master Nov 29, 2019
@xael-fry xael-fry added this to the 1.5.4 milestone Nov 29, 2019
@asolntsev asolntsev deleted the fix-loading-custom-session-store branch March 15, 2021 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xael-fry xael-fry xael-fry approved these changes

Assignees

@asolntsev asolntsev

Labels
defect
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.

Custom SessionStore throws ClassNotFoundException
2 participants
@asolntsev @xael-fry