[#4098] Make "play javadoc" fail if javadoc fails #1322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 16, 2019 13:05
xael-fry
approved these changes
Jan 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
play javadocto fail if javadoc fails. It follows the pattern of return code propagation in test.py and deps.py. The new failure message indicates where to look for the errors from javadoc.I manually confirmed that "play javadoc" shows the expected error as given by the repro steps in the Lighthouse bug report. I manually confirmed that
play javadocdoes not fail for any of the samples-and-tests with Java 8 despite the errors in the logs/javadoc.err files. I manually confirmed thatplay javadocdoes fail for samples-and-tests/yabe with Java 11 untilplay dependenciesis run, which is consistent with the behavior ofplay run. I did not add any automated tests because I didn't see where the "play" python script was tested.