Skip to content
This repository has been archived by the owner on Aug 20, 2024. It is now read-only.

Feature request: expect(frame: Frame) #66

Closed
fkranenburg opened this issue Mar 26, 2021 · 4 comments · Fixed by #68
Closed

Feature request: expect(frame: Frame) #66

fkranenburg opened this issue Mar 26, 2021 · 4 comments · Fixed by #68
Labels
enhancement New feature or request

Comments

@fkranenburg
Copy link

We have a lot of iframes inside our application and would like to test inside the iframe pages. It would be great if expect could also work with a Frame object.
@mmarkelov mmarkelov added the enhancement New feature or request label Mar 26, 2021
@mmarkelov mmarkelov mentioned this issue Mar 27, 2021
Merged
@southpolesteve
Copy link

Same. Would love to see this added.

@mmarkelov
Copy link
Member

@southpolesteve I just made some improvements to implement this logic. So think that it's ready for merge.
@mxschmitt could you please check this?
Thanks!

@mmarkelov
Copy link
Member

@mxschmitt i suppose that we should publish new version?

@mxschmitt
Copy link
Collaborator

@mxschmitt i suppose that we should publish new version?

yup sounds good to me

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add ability to handle Frame playwright-community/expect-playwright
4 participants
@southpolesteve @fkranenburg @mxschmitt @mmarkelov