Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload shortcut does not work #109

Closed
kovmir opened this issue Mar 29, 2024 · 4 comments
Closed

Upload shortcut does not work #109

kovmir opened this issue Mar 29, 2024 · 4 comments

Comments

@kovmir
Copy link
Contributor

kovmir commented Mar 29, 2024

I use gossa tag v1.0.0. My setup is dwm and librewolf. Nothing happens if I hit Ctrl + U, file picker does not appear. However, file picker works if I click the upload icon.

Also, do not hide the upload icon on desktop, please!

@kovmir
Copy link
Contributor Author

kovmir commented Aug 4, 2024

<input> picker was blocked due to lack of user activation. is what I get in console each time I hit ctrl+u.
Possible fix here.

@pldubouilh
Copy link
Owner

Ah right, that's an issue I saw in the past indeed, it's a limitation from the browser, where a user interaction is required in order to be able to catch keyboard actions. The fix mentioned feels like a bug in Firefox though 🫠
I'll close this up for the time being 👍

@pldubouilh
Copy link
Owner

Also, do not hide the upload icon on desktop, please!

@kovmir regarding this, I think I'll allow custom JS to be injected from the CLI in a future release. Also it'll help with #110, etc...

@kovmir
Copy link
Contributor Author

kovmir commented Aug 5, 2024

Why do you not want to include this natively? Unlike the keyboard shortcut, it works every time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants