Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: add an add subtitle function for video playing #62

Open
Sollovin opened this issue Aug 22, 2020 · 3 comments
Open

Feature request: add an add subtitle function for video playing #62

Sollovin opened this issue Aug 22, 2020 · 3 comments

Comments

@Sollovin
Copy link

Hello, as an nonnative English speaker, a function to add subtitles for the streaming videos would be very useful for me. Do you have any plan to implement such a functionality?

@pldubouilh
Copy link
Owner

Yes I'd like subtitles support as well - but sadly the html videoplayer doesnt support .srt :(

There are 2 options: using a JS library to fetch the .srt and mangle it to WebVTT client side, or mangle the subtitles server side so that the videplayer can read them natively.

I'm not really happy with either solutions as they both rely on external dependencies. I've been considering making a separate project, a proxy to convert videos from random formats to mp4, to make them readable by browsers (including subtitles then), but I'm not really sure of the relevance at this stage.

@lakuapik
Copy link

Hi @pldubouilh, thanks for this awesome project!

just asking, are you planning on adding native support for .vtt? i dont mind converting my srt to vtt manually, there seems plenty of online tools that can help to do that.

or do you still planning on adding .srt support just like what discussed above? many thanks.

@pldubouilh
Copy link
Owner

Hey @lakuapik, thanks for raising this issue again ! I'll re-open it and try think of solutions.
Supporting .vtt sounds like a good start indeed, as it's supported natively. If you feel like writing a PR, that's also welcomed :)

@pldubouilh pldubouilh reopened this Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants