Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Don't exclude null from oneOf return type #719

Merged
merged 1 commit into from
Jan 23, 2024
Merged

fix: Don't exclude null from oneOf return type #719

merged 1 commit into from
Jan 23, 2024

Conversation

jvvan
Copy link
Contributor

@jvvan jvvan commented Jan 22, 2024

Fixes the return type of types.oneOf.

Closes: #715

avaly
avaly approved these changes Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@avaly avaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jvvan for this fix!

@avaly avaly merged commit 47140c5 into plexinc:main Jan 23, 2024
5 checks passed
This was referenced Jan 23, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avaly avaly avaly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

oneOf removes null type
2 participants
@jvvan @avaly