-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Today" marker inaccurate in some views #189
Comments
@djmcquillan this might be related to react state and updating of the today marker because the today marker positioning is based entirely on the globalTimeScaler's |
if it's related to the scale itself, it's probably not going to be a quick item. |
@djmcquillan I moved this to in progress. lmk if you're not actively working on it |
FYI. I looked into this a bit and was unable to get it working right away but I addressed an issue with today marker rendering that was introduced in #219. P.S. https://www.starmaps.app/roadmap/github.com/cryptonetlab/roadmap/issues/21?mode=d3#simple shows an accurate timeline with d3, though some styling needs updating. It's so much more accurate with d3... |
This seems to be related to some special CSS-grid logic when there are stacked milestone cards. This is not reproducible when rendering a root issue that doesn't have stacked children. |
This issue is blocked by #237 |
Note that this is fixed in #237 (but needs some style updates). see #237 (comment) |
Closing this in favor of #237 |
Date marker appears correctly in some views (see parent milestone: https://www.starmaps.app/roadmap/github.com/cryptonetlab/roadmap/issues/1) and incorrectly in others (see child milestone: https://www.starmaps.app/roadmap/github.com/cryptonetlab/roadmap/issues/21)
Screenshot:
Parent Milestone (Mostly Correct)
Child Milestone (Incorrect)
The text was updated successfully, but these errors were encountered: