Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Today" marker inaccurate in some views #189

Closed
Tracked by #237
juliaxbow opened this issue Nov 25, 2022 · 9 comments
Closed
Tracked by #237

"Today" marker inaccurate in some views #189

juliaxbow opened this issue Nov 25, 2022 · 9 comments
Labels
bug Something isn't working effort/hours The work in this issue, which should be status/ready, should take less than 1/2 day to complete MVP P0 status/needs-clarification This issue requires further information prior to becoming ready for work

Comments

@juliaxbow
Copy link
Collaborator

juliaxbow commented Nov 25, 2022

Date marker appears correctly in some views (see parent milestone: https://www.starmaps.app/roadmap/github.com/cryptonetlab/roadmap/issues/1) and incorrectly in others (see child milestone: https://www.starmaps.app/roadmap/github.com/cryptonetlab/roadmap/issues/21)

Screenshot:
Parent Milestone (Mostly Correct)
Screen Shot 2022-11-25 at 10 14 49 AM

Child Milestone (Incorrect)
Screen Shot 2022-11-25 at 10 12 53 AM

@juliaxbow juliaxbow added bug Something isn't working P0 labels Nov 25, 2022
@SgtPooki SgtPooki added MVP effort/hours The work in this issue, which should be status/ready, should take less than 1/2 day to complete status/ready This issue has enough information to be worked on and no technical blockers or pre-reqs labels Nov 26, 2022
@0xDanomite 0xDanomite self-assigned this Nov 28, 2022
@SgtPooki
Copy link
Contributor

@djmcquillan this might be related to react state and updating of the today marker because the today marker positioning is based entirely on the globalTimeScaler's getPercentage function based on date.

@SgtPooki
Copy link
Contributor

if it's related to the scale itself, it's probably not going to be a quick item.

@SgtPooki
Copy link
Contributor

@djmcquillan I moved this to in progress. lmk if you're not actively working on it

@0xDanomite 0xDanomite removed their assignment Dec 1, 2022
@0xDanomite
Copy link
Contributor

@SgtPooki as discussed we will revisit this once #219 is merged

@SgtPooki SgtPooki self-assigned this Dec 2, 2022
@SgtPooki
Copy link
Contributor

SgtPooki commented Dec 2, 2022

FYI. I looked into this a bit and was unable to get it working right away but I addressed an issue with today marker rendering that was introduced in #219.

P.S. https://www.starmaps.app/roadmap/github.com/cryptonetlab/roadmap/issues/21?mode=d3#simple shows an accurate timeline with d3, though some styling needs updating. It's so much more accurate with d3...

@SgtPooki
Copy link
Contributor

SgtPooki commented Dec 2, 2022

This seems to be related to some special CSS-grid logic when there are stacked milestone cards. This is not reproducible when rendering a root issue that doesn't have stacked children.

@SgtPooki SgtPooki added status/needs-clarification This issue requires further information prior to becoming ready for work and removed status/ready This issue has enough information to be worked on and no technical blockers or pre-reqs labels Jan 23, 2023
@SgtPooki
Copy link
Contributor

This issue is blocked by #237

@SgtPooki SgtPooki removed their assignment Jan 23, 2023
@SgtPooki
Copy link
Contributor

Note that this is fixed in #237 (but needs some style updates). see #237 (comment)

@SgtPooki
Copy link
Contributor

SgtPooki commented May 5, 2023

Closing this in favor of #237

@SgtPooki SgtPooki closed this as not planned Won't fix, can't repro, duplicate, stale May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working effort/hours The work in this issue, which should be status/ready, should take less than 1/2 day to complete MVP P0 status/needs-clarification This issue requires further information prior to becoming ready for work
Projects
Archived in project
Development

No branches or pull requests

3 participants