-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: milestone alignment is off #236
Comments
Note that milestone card accuracy is fine (i.e. as accurate as we can get until #237 ) when running locally in dev mode: But not on starmaps.app: I believe this is related to the dev-only react "strict mode" configuration which is causing more renders than normally happens in production mode |
Confirmed the issue is related to multiple-renderings. See screenshot with What does this mean, is this issue fixable?Yes, the issue is fixable. Some state changes are happening that are not being listened to appropriately. The data is updated with strictMode=true, the milestone positioning is accurate, but some async updates are not resulting in another render cycle when they should. ETA for fix: EOD 2022-12-05 |
@SgtPooki The first milestone on drand roadmap is still not at the right place: it's ending on 2022-12-31 and yet is rendered as ending on 2023-03-31 on your last screenshot. |
from slack thread: https://filecoinproject.slack.com/archives/C0418TBQ9CH/p1669991912016049
example roadmaps that are showing inaccurate milestones:
The text was updated successfully, but these errors were encountered: