Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: milestone alignment is off #236

Closed
SgtPooki opened this issue Dec 5, 2022 · 3 comments · Fixed by #238
Closed

bug: milestone alignment is off #236

SgtPooki opened this issue Dec 5, 2022 · 3 comments · Fixed by #238
Assignees
Labels
bug Something isn't working effort/days The work in this issue, which should be status/ready, should take less than a week to complete MVP P0 status/ready This issue has enough information to be worked on and no technical blockers or pre-reqs

Comments

@SgtPooki
Copy link
Contributor

SgtPooki commented Dec 5, 2022

from slack thread: https://filecoinproject.slack.com/archives/C0418TBQ9CH/p1669991912016049

example roadmaps that are showing inaccurate milestones:

@SgtPooki SgtPooki added bug Something isn't working MVP status/ready This issue has enough information to be worked on and no technical blockers or pre-reqs effort/days The work in this issue, which should be status/ready, should take less than a week to complete P0 labels Dec 5, 2022
@SgtPooki SgtPooki self-assigned this Dec 5, 2022
@SgtPooki
Copy link
Contributor Author

SgtPooki commented Dec 5, 2022

Note that milestone card accuracy is fine (i.e. as accurate as we can get until #237 ) when running locally in dev mode:

image

But not on starmaps.app:

image

I believe this is related to the dev-only react "strict mode" configuration which is causing more renders than normally happens in production mode

@SgtPooki
Copy link
Contributor Author

SgtPooki commented Dec 5, 2022

Confirmed the issue is related to multiple-renderings. See screenshot with reactStrictMode: false when running dev mode locally:

image

What does this mean, is this issue fixable?

Yes, the issue is fixable. Some state changes are happening that are not being listened to appropriately. The data is updated with strictMode=true, the milestone positioning is accurate, but some async updates are not resulting in another render cycle when they should.

ETA for fix: EOD 2022-12-05

@SgtPooki SgtPooki linked a pull request Dec 5, 2022 that will close this issue
@AnomalRoil
Copy link

@SgtPooki The first milestone on drand roadmap is still not at the right place: it's ending on 2022-12-31 and yet is rendered as ending on 2023-03-31 on your last screenshot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working effort/days The work in this issue, which should be status/ready, should take less than a week to complete MVP P0 status/ready This issue has enough information to be worked on and no technical blockers or pre-reqs
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants