New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change base server to Starlette #1022

Open

bloodbare opened this issue Oct 22, 2020 · 1 comment

Labels

enhancement GIP wip

Milestone

Member

bloodbare commented Oct 22, 2020 •

edited

Loading

Change the base of Guillotina to be Starlette.

Right now we use basic uvicorn http server and we provide ASGI on top of it.

My proposal is to provide a RouteMatcher for Starlette and use the request object of Startlette.

We can remove then static file serving.

bloodbare added enhancement wip labels

bloodbare added this to the G7 milestone

bloodbare added the GIP label

Member Author

bloodbare commented Feb 16, 2021

We will document how to run Guillotina with starlette / Fastapi instead of changing base code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment