Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve i18n of info window #76

Open
erral opened this issue Jun 22, 2020 · 0 comments
Open

Improve i18n of info window #76

erral opened this issue Jun 22, 2020 · 0 comments

Comments

@erral
Copy link
Member

erral commented Jun 22, 2020

Info window is not properly i18nized.

See the template: https://github.com/plone/plone.app.linkintegrity/blob/master/plone/app/linkintegrity/browser/delete_confirmation_info.pt#L67

See the view:
https://github.com/plone/plone.app.linkintegrity/blob/master/plone/app/linkintegrity/browser/info.py#L94 and https://github.com/plone/plone.app.linkintegrity/blob/master/plone/app/linkintegrity/browser/info.py#L195

Template message is built in 2 steps where the number always goes first. In some languages this is not OK and the number should go afterwards.

The msgids should contain a variable and the template should use i18n:name style attribute to fill them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant