Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let ZIP import automatically handle common off-the-shelf theme scenarios #32

Closed
fulv opened this issue Oct 22, 2016 · 2 comments
Closed

Comments

@fulv
Copy link
Member

fulv commented Oct 22, 2016

Currently, when you import a zip file for a non-Plone theme, several steps need to be done manually. That is even in the best-case scenario where a theme is actually quite well-behaved right off the shelf, e.g. startbootstrap.

Two things would be very easy and risk-free to implement:

  1. If a manifest.cfg file is not present in the zip file, create it automatically.
  2. Automatically parse the src and href attributes in the index.html file to fix the paths to any images, and other resources.

I am hoping to implement this today at the ploneconf sprint.

@pigeonflight @jean @ebrehault @datakurre

@davisagli
Copy link
Member

I think you meant to file this in plone.app.theming rather than plone.app.testing

@fulv
Copy link
Member Author

fulv commented Oct 24, 2016

@davisagli Indeed! My bad.

plone/plone.app.theming#116

@fulv fulv closed this as completed Oct 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants