Statusmessage type is untranslated when using @@ploneform-macros/form with different domain from another package

[fredvd]

I'm looking into a weird translation problem where collective.easyform 'global' form errors have an untranslated type. It always says 'Error' in every language. This might be a problem in the way collective.easyform is calling the macro, where the calling template has i18n:domain set to collective.easyform instead of plone :

https://github.com/collective/collective.easyform/blob/5d18bce01c104ae44fc3a11086a4f7475951aa93/src/collective/easyform/browser/easyform_form.pt#L1-L6

it is this part in the form macros.pt which isn't translated:

plone.app.z3cform/plone/app/z3cform/templates/macros.pt

Lines 20 to 22 in 86326cf

	<dt i18n:translate="">
	Error
	</dt>

A solution would be to add i18n:domain="plone" to line 20 . As said, I'm not sure if the problem isn't in easyform, because a lot of the translations for validation errors and other messages are duplicated in the collective.easyform domain. See the screenshots below for the testform views in Dutch and German, collective.easyform doesn't have Dutch translations (but does have German ones), but all error mesages are still translated in Dutch.

On the other hand, i18ndude cannot pick up these translations for the status message type as they are in plone.app.z3cform: To fix this in easyform I'd have to add an extra collective-easform-manual.pot which has to be merged with the translations picked up by i18ndude. Which is also double work for every addon using z3c.form macros.

@mauritsvanrees Found it...

[mauritsvanrees]

Adding i18n:domain="plone" sounds good to me.

[jensens]

#40 could be related

[fredvd]

I think we should just add the i18n:domain and then it's solved. I'll create a PR.