Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upgrade steps for last_compilation dates #19

Closed
thet opened this issue Mar 4, 2019 · 3 comments
Closed

Add upgrade steps for last_compilation dates #19

thet opened this issue Mar 4, 2019 · 3 comments

Comments

@thet
Copy link
Member

thet commented Mar 4, 2019

Currently for a new bundle build we need to update the last_compilation dates in bundles.xml and additionally in plone.app.upgrade.
This process is tedious because for each fix you immediately have to track two distinct repositories.

@ale-rt @mauritsvanrees what to you think of moving all last_compilation date updates from plone.app.upgrade into here? Then we'd only need to update that in here which makes the upgrade process a lot simpler I guess.

@ale-rt
Copy link
Member

ale-rt commented Mar 4, 2019

I am +1.
It also follows the same philosophy of PLIP plone/Products.CMFPlone#1653 to centralize in this package everything that is related to static resources.
In some cases also other registry records might need to be updated if some of these files needs an update: https://github.com/plone/plone.staticresources/tree/master/src/plone/staticresources/profiles/default/registry

@mauritsvanrees
Copy link
Member

Makes sense. So:

  1. Create upgrade steps in plone.staticresources.
  2. Add the plone.staticresources:default profile to the ADDON_LIST in CMFPlone.MigrationTool so all its available upgrade steps are always automatically applied during a @@plone-upgrade.

That should work.

@thet
Copy link
Member Author

thet commented Nov 3, 2019

Done with: plone/Products.CMFPlone#2976
Thanks for the pointer @mauritsvanrees !

@thet thet closed this as completed Nov 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants