Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arrow in menu and livesearch checkbox not vertically aligned #202

Closed
vincentfretin opened this issue Jul 1, 2020 · 5 comments
Closed

arrow in menu and livesearch checkbox not vertically aligned #202

vincentfretin opened this issue Jul 1, 2020 · 5 comments

Comments

@vincentfretin
Copy link
Member

vincentfretin commented Jul 1, 2020

In Plone 5.2.2 / plonetheme.barceloneta 2.1.7
the arrow in menu and livesearch checkbox are not vertically aligned.

Chrome + Ubuntu 18.04
Capture d’écran de 2020-07-01 15-56-17

For the checkbox in livesearch, I'm wondering if it's not OS specific.
I'm on Ubuntu 18.04. What do you folks have? Can you please share a screenshot in macOS or Windows? @ale-rt ?

Better looking should be:
Capture d’écran de 2020-07-01 16-09-09

Do you agree?

input[type="radio"], input[type="checkbox"] {
    /* margin: 4px 0 0;*/
}

@media (min-width: 768px) {
.plone-nav li label:after {
    padding: 0.75em 1em 0em 0; // instead of 0.5em 1em 0.5em 0
}
}
@vincentfretin
Copy link
Member Author

Ha ha, commenting the checkbox rule to fix the livesearch checkbox changed the checkbox in resources registry, now its not aligned anymore. :-)

@ale-rt
Copy link
Member

ale-rt commented Jul 1, 2020

Chrome + Ubuntu 20.04
image
Firefox + Ubuntu 20.04
image
The arrow looks slightly better aligned with FF, but the check box is broken in both.
I agree with removing the checkbox margin maybe .searchSection to make it specific.

@vincentfretin
Copy link
Member Author

Ha ha, why do have a smaller arrow in FF Ubuntu 20.04? :)
My previous screenshot was on Chrome Ubuntu 18.04.

Chrome + Ubuntu 18.04
Capture d’écran de 2020-07-01 16-48-51

Firefox + Ubuntu 18.04
Capture d’écran de 2020-07-01 16-49-21
The arrow alignment seems perfect on this one.

@vincentfretin
Copy link
Member Author

vincentfretin commented Jul 7, 2020

In PR #206 the commit 32dea29 fix the issue for the search checkbox with vertical-align: middle on the label and removing the margin on the checkbox. (tested with Firefox 78 and Chrome 83 on Ubuntu 18.04 and Safari on iPad iOS 13.5.1)
Capture d’écran de 2020-07-07 17-23-25

@vincentfretin
Copy link
Member Author

I gave up for the arrow, it will stay like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants