Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow running GitHub Actions or workflows on pull_request event #4346

Open
stevepiercy opened this issue Feb 2, 2023 · 0 comments
Open

Allow running GitHub Actions or workflows on pull_request event #4346

stevepiercy opened this issue Feb 2, 2023 · 0 comments

Comments

@stevepiercy
Copy link
Collaborator

GitHub Actions (workflows) currently run only when someone opens a branch in the plone/volto repository, and not from forks. Should we open that up?

The effort to do so is minimal. It means editing our existing workflows to execute on a pull_request event instead of a push.

Currently the push event only is an annoying barrier, as external branches do not run workflows. We can still require the Plone Contributor Agreement, and @mister-roboto happily nags the contributor to do so. The risk is minimal.

The downside is that external forks typically are not writeable except by the owner, and thus do not allow others to amend the pull request.

I'd suggest this as a topic of discussion at Alpine City Sprint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant