Experimental feature flag for new add block button enabled by default.

[sneridagh]

How we did we would do this?

• Next major (17) we flip the experimental flag to true
• In two majors (18) we make it default? (I hope that by then we have Quanta Toolbar around, tbh).

[netlify]

✅ Deploy Preview for volto canceled.

Name	Link
🔨 Latest commit	0fbdd7c
🔍 Latest deploy log	https://app.netlify.com/sites/volto/deploys/654781214d9a59000891d21c

[cypress]

4 failed tests on run #7051 ↗︎

4

557

20

0

0

Details:

Merge branch 'master' into newbuttonoutofexperimental
Project: Volto	Commit: 6566e3d2fe
Status: Failed	Duration: 17:36 💡
Started: Aug 29, 2023 10:47 AM	Ended: Aug 29, 2023 11:05 AM

  blocks/block-anchors.js • 1 failed test • Core Blocks 18.x

View Output Video

Test		Artifacts
Block Tests: Anchors > Add Block: add content to TOC		Output Screenshots Video

  volto-slate/03-block-slate.js • 1 failed test • Core Volto Slate 18.x

View Output Video

Test		Artifacts
Block Tests > should show block chooser btn on adding new text block created from the previous block with the formatted content		Output Screenshots Video

  volto-slate/03-block-slate.js • 1 failed test • Core Volto Slate 16.x

View Output Video

Test		Artifacts
Block Tests > should show block chooser btn on adding new text block created from the previous block with the formatted content		Output Screenshots Video

  blocks/block-anchors.js • 1 failed test • Core Blocks 16.x

View Output Video

Test		Artifacts
Block Tests: Anchors > Add Block: add content to TOC		Output Screenshots Video

_{This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.}

[rotavio]

We are using some addons that allows adding blocks inside other blocks, like columns, tabs and accordion. There are some issues with these blocks when the experimental feature is enabled.

Is the "block inside block" feature native or created by the addons team?

Is there something like this native to Volto? If no, are there plans for it?

[sneridagh]

@rotavio there is no such add-ons team, only their authors. These change the behavior of the add button in the main stream of blocks. The management of the "blocks in block" use case is done internally by the add-ons (using their own handlers).

Recently we included in latest 17a16 the primitive container and the grid block in core. However, these are also detached from the mentioned feature, having their own means and UX to add blocks inside.

I am personally not aware that there are issues with other addons (there are none in the core grid).

/cc @avoinea @tiberiuichim ?

[rotavio]

Thank you for the information. I understand.
What I mean by issues are not exactly errors, but little annoyances when adding blocks. You have to add a text block. The add button appears only on the last text block of the array.
But i understand how this is not a volto issue. Thanks!

[sneridagh]

@rotavio It would be great if you could provide exact instructions for reproducing the annoyance, and screenshots/video. Which add-on are you working with? etc. Thanks!

[sneridagh]

@plone/volto-team I had further discussions regarding this matter with a couple Team members who brought up good points:

1.- We really haven't yet a proper alpha testing for including the feature by default

This is utterly true, and I didn't realise this has to be the case always. So doing it now at the end of the alpha phase of 17 is useless.

2.- The feedback is still quite few, and a proper alpha phase would have helped. Mostly because of 1.

3.- We still are unsure of the final shape that the Experimental / Future / Feature flags should have, we decided not to change the current shape

So I propose to slate this until 18, the first alpha would have it enabled by default (in the shape of the current experimental flag, but turned on). During beta/RC/final release, and if we decide to have it as a default feature, then it should abandon the form of the "experimental" flag and be just another "settings" key (turnable off).