Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Blocks/Video/Edit component #4960

Merged
merged 18 commits into from
Aug 13, 2024
Merged

Refactor Blocks/Video/Edit component #4960

merged 18 commits into from
Aug 13, 2024

Conversation

Tishasoumya-02
Copy link
Contributor

@netlify
Copy link

netlify bot commented Jul 8, 2023 •
edited
Loading

✅ Deploy Preview for volto canceled.

Name Link
🔨 Latest commit c9178f6
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/64d498f86530910008685237

@cypress
Copy link

cypress bot commented Jul 8, 2023 •
edited
Loading

Passing run #6801 ↗︎

0 553 20 0 Flakiness 0

Details:

Storybook update
Project: Volto Commit: c9178f671b
Status: Passed Duration: 12:41 💡
Started: Aug 10, 2023 8:03 AM Ended: Aug 10, 2023 8:15 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@JeffersonBledsoe JeffersonBledsoe mentioned this pull request Jul 8, 2023
Open
93 tasks
@iFlameing
Copy link
Member

@sneridagh I think we should add default props and prop types to the functional components also. What do you think?

@FreakForever FreakForever mentioned this pull request Jul 23, 2024
Closed
@netlify Netlify
Copy link

netlify bot commented Aug 12, 2024 •
edited
Loading

✅ Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit 732afac
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/66bb088b3b0a0600080ad350

@Tishasoumya-02 Tishasoumya-02 self-assigned this Aug 12, 2024
@davisagli davisagli merged commit 1710f8b into main Aug 13, 2024
70 checks passed
@davisagli davisagli deleted the block-video-refactor branch August 13, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nileshgulia1 nileshgulia1 nileshgulia1 approved these changes

@davisagli davisagli davisagli approved these changes

@sneridagh sneridagh Awaiting requested review from sneridagh

@JeffersonBledsoe JeffersonBledsoe Awaiting requested review from JeffersonBledsoe

Assignees

@Tishasoumya-02 Tishasoumya-02

Labels
24 status: ready 32 needs: review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Tishasoumya-02 @iFlameing @davisagli @nileshgulia1