-
-
Notifications
You must be signed in to change notification settings - Fork 739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hamburger Icon in small screen is not working #5353
Comments
@sneridagh Please assign this to me. |
@Aarav238 We do not assign issues in the plone organization. Please follow our contribution guidelines: https://6.docs.plone.org/contributing/first-time.html |
The hamburger menu is only empty if there are no items in the site's navigation. In that case it would make sense to hide the hamburger icon. |
Yeah @davisagli , that will be better than removing it, So I have signed the contributor agreement. How much will it take for confirmation? |
@Aarav238 if you read First-time contributors, then you would have read the linked section Contributing to Plone, which contains the answer you seek. |
Yeah thanks @stevepiercy , I have signed the agreement and am excited to contribute. |
@davisagli @Aarav238 Personally I think that we are trying to solve a non-existent issue as in real-world scenarios Volto is tied to a CMS which by definition has content that requires navigating the website. |
@ichim-david Thanks for this, So should I work on this @davisagli ? |
@Aarav238 You're welcome to work on it if you want to. I agree with @ichim-david that it's not a critical issue, but it also sounds pretty easy to fix. |
Okay @davisagli , I wil raise a PR as soon as possible. Thanks !! |
@davisagli I have read the contribution documentation , so can you please how to setup volto for development locally ? |
@Aarav238 now continue your education by reading more of the same documentation at https://6.docs.plone.org/install/install-from-packages.html. We do not provide support on GitHub. If you need support, use https://community.plone.org/. |
Hello there, I hope this message finds you well. I'm relatively new to the Plone community. I've successfully set up the project on my local laptop, and I'm enthusiastic about contributing to Volto. We can solve the above issue by using these steps
can you help me that these steps is suitable or not for above issue? Your assistance will be greatly appreciated. Thank you! |
@Ravi-kumar9347 I think now it is working properly , it rendering those items from props ig and we need to check when we are not getting any items in props for navigation. |
@Ravi-kumar9347 You setup this using containers or locally? |
I set up backend and frontend locally |
@Aarav238 can you please help me to find out the css files? |
There is no need of finding css files , just check whether items are empty or not and conditionally render the icon. |
Describe the bug
Hamburger icon is not containing any data and it is useless to keep this in the navbar.
To Reproduce
we can remove this icon or make it disable, we can also give some list that will render when we click on icon.
Expected behavior
It should not be there or should not show blank page on clicking on it.
Screenshots
If applicable, add screenshots to help explain your problem.
Software (please complete the following information):
The text was updated successfully, but these errors were encountered: