Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve wording in branching policy #5372

Merged
merged 5 commits into from
Nov 6, 2023
Merged

Conversation

sneridagh
Copy link
Member

No description provided.

Copy link

netlify bot commented Nov 6, 2023

Deploy Preview for volto ready!

Name Link
🔨 Latest commit 0395071
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/654910b59195ea00080346b5
😎 Deploy Preview https://deploy-preview-5372--volto.netlify.app/contributing/index.html
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use past tense on news item.

news/5372.documentation Outdated Show resolved Hide resolved
@@ -32,7 +32,7 @@ canary
`17.x.x`
: `17.x.x` is the current stable and actively developed branch in git.
Upon the final release of version `18.0.0`, the `17.x.x` branch line will be no longer supported.
Any new feature will be generally released to the `main` branch, and only backported to older versions if the Volto Team approves it.
Any new feature will be merged into the `main` branch, and only backported to and released in older versions, if the Volto Team approves it.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And the same change on line 40, please

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @davisagli

@sneridagh sneridagh merged commit baa1cca into main Nov 6, 2023
49 checks passed
@sneridagh sneridagh deleted the improvewordingbranchpolicy branch November 6, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants