Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated acceptance tests docs #5533

Merged
merged 2 commits into from
Dec 18, 2023

Conversation

sneridagh
Copy link
Member

The "good" ones are in docs/source/contributing/acceptance-tests.md

Copy link

netlify bot commented Dec 14, 2023

Deploy Preview for volto ready!

Name Link
🔨 Latest commit d69d404
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/657b22787920d500082b45e4
😎 Deploy Preview https://deploy-preview-5533--volto.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Out of curiosity, do we have current docs for acceptance tests somewhere?

@stevepiercy stevepiercy self-requested a review December 14, 2023 16:10
@stevepiercy
Copy link
Collaborator

nm, answered my own question: https://6.docs.plone.org/volto/contributing/acceptance-tests.html

But that begs the question, why do we break apart testing into separate pages?

@ichim-david
Copy link
Member

ichim-david commented Dec 17, 2023

nm, answered my own question: https://6.docs.plone.org/volto/contributing/acceptance-tests.html

But that begs the question, why do we break apart testing into separate pages?

@stevepiercy you make a good point maybe the better enhancement would be to bring the acceptance testing
to replace the section that is deleted so that the testing is in one place only.
The acceptance section is larger but we have the TOC to the right so I guess navigation wouldn't be a problem

@sneridagh
Copy link
Member Author

sneridagh commented Dec 18, 2023

@stevepiercy I think acceptance testing is big (and important in Volto) enough to have its own section. Not all testing forms are created equal, and I think it's worth to separate them to make this remark.

@sneridagh sneridagh merged commit 64084cb into main Dec 18, 2023
52 checks passed
@sneridagh sneridagh deleted the removeoutdatedacceptancetestsdocs branch December 18, 2023 10:08
pranayjoshi pushed a commit to pranayjoshi/volto that referenced this pull request Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants