Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DefaultView.jsx with Absolute Path for RenderBlocks #5917

Merged
merged 8 commits into from
Mar 31, 2024

Conversation

agan-k
Copy link
Member

@agan-k agan-k commented Mar 24, 2024

When copied to customization the RenderBlocks component can't be reached with a relative path.

Copy link

netlify bot commented Mar 24, 2024

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit 0b8c56a
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/660806e8387d830008e83566

Copy link

netlify bot commented Mar 24, 2024

Deploy Preview for volto canceled.

Name Link
🔨 Latest commit 0b8c56a
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/660806e8d4a36200083e5c3d

@sneridagh
Copy link
Member

@agan-k we need a changelog.

@agan-k
Copy link
Member Author

agan-k commented Mar 27, 2024

@agan-k we need a changelog.

@sneridagh any chance we could merge this? Thanks!

Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The suggestion change to the change log is a little more descriptive.

packages/volto/news/5917.internal Outdated Show resolved Hide resolved
Co-authored-by: Steve Piercy <web@stevepiercy.com>
@agan-k agan-k requested a review from stevepiercy March 27, 2024 21:48
Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good small improvement. Thanks.

@davisagli davisagli merged commit 7adc545 into plone:main Mar 31, 2024
47 checks passed
@agan-k agan-k deleted the patch-1 branch March 31, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants