Remove react-share library and SocialSharing component
#6162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for plone-components canceled.
|
ichim-david
approved these changes
Jul 10, 2024
|
@stevepiercy Merging, since this is breking builds right now. |
sneridagh
added a commit
that referenced
this pull request
Jul 11, 2024
* main: Remove `react-share` library and `SocialSharing` component (#6162)
|
@sneridagh I just created a new project with cookieplone because I wanted to finally try it and maybe jump on board and bumped into this. Maybe releasing a new alpha would help people that create new projects like I did. I can easily change mrs-developer for now so no rush, but I think it's needed. |
|
@pnicolli Today I knew that I overlooked that we would need a release for this, and I missed to do so. I will release Volto asap, I'll try this evening. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The builds start to break because of
react-sharetoday, dependencies problem because we are using an ancient version.Let's remove it, since core is not using it anymore.
📚 Documentation preview 📚: https://volto--6162.org.readthedocs.build/