Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle form.ui.hovered #6240

Merged
merged 3 commits into from
Aug 6, 2024
Merged

fix: handle form.ui.hovered #6240

merged 3 commits into from
Aug 6, 2024

Conversation

giuliaghisini
Copy link
Contributor

@giuliaghisini giuliaghisini commented Aug 6, 2024

fixed change of form.ui.hovered when editing blocks, because if you have a FormBlock component inside another one,
onMouseOver fires for all stacked blocks and you cannot use the nested form.

working example:

Registrazione.schermo.2024-08-06.alle.12.02.49.mov

Copy link

netlify bot commented Aug 6, 2024

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit 05b3fc7
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/66b1f726af7f8e0008c4c8d5

@stevepiercy
Copy link
Collaborator

@giuliaghisini did you mean to include files under the api/ directory? I think that was a mistake.

@stevepiercy
Copy link
Collaborator

@giuliaghisini btw, we recently updated documentation with the current best practice of using Docker on the backend. The api folder is outdated. See https://6.docs.plone.org/volto/contributing/developing-core.html#start-the-backend-and-volto

Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix makes sense to me.

@davisagli davisagli merged commit ac85e20 into main Aug 6, 2024
70 checks passed
@davisagli davisagli deleted the fix_handle_form_ui_hovered branch August 6, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants