Fix edge case in ContentsPropertiesModal #6258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for plone-components canceled.
|
|
@davisagli of course you found a bug after backporting to 16 and 17 :)). Talking about bad karma alert :). Maybe a cypress test wouldn't hurt for this functionality |
|
@ichim-david Yes, I found the bug once I was testing it integrated with a project. I'm not sure a cypress test would have helped in this case, because it's a bit of an obscure one that I probably wouldn't have thought to test. Are there any existing Cypress tests for the contents view? I looked but didn't find any. We should absolutely have some, but that's a bigger project than I anticipated when I started working on this change to the properties modal. |
ichim-david
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The item can be undefined if it's in this.state.selected but not this.state.items. This can happen after navigating to a different folder.