Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version is hardocoded #10

Open
edublancas opened this issue Aug 13, 2022 · 2 comments
Open

version is hardocoded #10

edublancas opened this issue Aug 13, 2022 · 2 comments
Labels
good first issue Good for newcomers

Comments

@edublancas
Copy link
Contributor

this should be package, specific:

TELEMETRY_VERSION = '0.3'

@idomic
Copy link
Contributor

idomic commented Aug 15, 2022

@edublancas this is so we know the telemetry version running with the product right?
like if it'll say ploomber 0.20 how would you know which telemetry is it?

@edublancas
Copy link
Contributor Author

yeah exactly. I think the purpose of posthog's telemetry version is to version schema changes. right now, all packages will say 0.3, but they should have independent versions as the telemetry schema for each will be different, essentially we want the Telemetry class to take this as an argument

to simplify things, we should make it an optional argument so that when we release this new version; it doesn't break existing packages. then open a PR in ploomber and set the value to 0.3- however, that ploomber PR is currently blocked by ploomber/ploomber#960 - we need to merge that first

@edublancas edublancas added the good first issue Good for newcomers label May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants