-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ploomber-core telemetry breaks jupysql when executing on a read only filesystem #63
Comments
thanks for the report! we'll take a look and fix it btw, check out ploomber-engine, it's a drop-in replacement for papermill with enhanced capabilities! |
Thanks! and thanks for moving, wasn't sure whether to make this in jupysql or ploomber-core. |
AC Criteria:
|
the default value isn't the /tmp/ directory, it's a different one. but that's fine. the idea is that the Config class should work ok in read-only filesystems. it should just skip the filesystem operations and initialize with the default values every time |
Update: I understand it now Yes, I understand that. But as far as I understood config class, all the functions are written such that, they write to a file. So, I need somewhere to write the file. This is the preliminary understanding, i am still exploring it. Do you want me to change config class, or make a new class such that we don't have to write to a file, even a tmpfile and all the operations can be done in-memory? |
hey @dancoates, we just released ploomber-core 0.2.13 with this fix. if the filesystem is read-only, it won't attempt to write the file. if you encounter any other problems, feel free to open an issue! |
Fantastic, thank you for the fix @edublancas |
We use papermill to execute jupyter notebooks on AWS lambda functions. The AWS Lambda filesystem is readonly except for the /tmp directory. When the jupysql extension is loaded the
telemetry.py
file in ploomber-core attempts to create a folder at~/.ploomber
by default. This throws an error and causes the execution of the notebook to fail.This can be pretty easily worked around by setting:
But it would be good if the telemetry.py file in ploomber-core either wasn't executed at all, or if it does need to be executed, if it more gracefully handled the situation where it is unable to create the config directory.
The text was updated successfully, but these errors were encountered: