-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logging future warning #65
Logging future warning #65
Conversation
@edublancas
This is because we want to record the module (jupysql, ploomber...), which invokes the If we create the telemetry instance from ploomber-core and use it, we will hard to see which module invokes the |
Do we need to add changelog entry? looks good besides this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please document this new approach here: https://ploomber-core.readthedocs.io/en/latest/deprecation.html
and add some context (the context is described in the original issue, which explains why we need this vs the existing deprecated module)
closes #50
Changes:
📚 Documentation preview 📚: https://ploomber-core--65.org.readthedocs.build/en/65/