Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing image tests for %sqlplot #526

Closed
edublancas opened this issue May 26, 2023 · 2 comments · Fixed by #628
Closed

missing image tests for %sqlplot #526

edublancas opened this issue May 26, 2023 · 2 comments · Fixed by #628
Assignees

Comments

@edublancas
Copy link

we're not testing the outputs of the %sqlplot command

in #508, we'll add tests for %sqlplot bar and %sqlplot pie, but we need to add for the others.

the ggplot API has image tests, so we can use that code as reference

@edublancas
Copy link
Author

I think we've added somet tests lately so we need to double check if we're missing tests

@mehtamohit013
Copy link

AC Criteria:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants