Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement breaks in histogram's ggplot #719

Closed
edublancas opened this issue Jul 10, 2023 · 3 comments · Fixed by #767
Closed

implement breaks in histogram's ggplot #719

edublancas opened this issue Jul 10, 2023 · 3 comments · Fixed by #767
Assignees

Comments

@edublancas
Copy link

once we close #711

we can implement breaks: #711 (comment)

@bbeat2782
Copy link

Acceptance Criteria

  1. Implement breaks like in ggplot in R (Default should be None. Thus, bins should be used by default and use breaks only if a user specifies one.)
  2. Add documentation to explain how to use breaks
  3. Add test functions

I have one question about the implementation. In R, when both bins and breaks are provided, breaks takes precedence over bins, so breaks argument is used. Do we want to replicate this or do you think raising an error is more appropriate?

@edublancas
Copy link
Author

I have one question about the implementation. In R, when both bins and breaks are provided, breaks takes precedence over bins, so breaks argument is used. Do we want to replicate this or do you think raising an error is more appropriate?

An error when both bins and breaks are passed is better.

@bbeat2782
Copy link

okay I will raise an error

@bbeat2782 bbeat2782 mentioned this issue Jul 28, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants