Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

showing feedback when starting a new connection #807

Closed
edublancas opened this issue Aug 16, 2023 · 1 comment · Fixed by #834
Closed

showing feedback when starting a new connection #807

edublancas opened this issue Aug 16, 2023 · 1 comment · Fixed by #834
Assignees

Comments

@edublancas
Copy link

edublancas commented Aug 16, 2023

we're currently not displaying any feedback when creating a new connection, but we should display something like "Connected to {alias}". This should be configurable and turned off when feedback=0

Likewise, the "switching to connection" messages should be turned off when feedback=0

you can get the current feedback level with: https://github.com/ploomber/jupysql/blob/master/src/sql/_current.py

@bbeat2782
Copy link

Acceptance Criteria

  1. Display a Connected to {alias} message that is configurable with feedback=0 when starting the first connection
  2. Add test functions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants