Use the configured repository when running exporting AWS Batch jobs with --skip-docker
#131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith `--skip-docker`.
|
@DennisJLi please check the tests |
|
@edublancas Any insight or leads on why this test might be failing? I can look into it but have zero context as it's for a backend and configuration options that are not related to any of my changes and only fails on one of the CI builds strangely... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
The soopervisor.yaml file for AWS Batch expects a
repository, but when runningsoopervisor export ... --skip-dockertherepositorysetting is not used as the image name, instead the default package is. This causes issues if we want to package the Docker container and submit to ECR repositories outside ofsoopervisor.This change makes it so that it always uses the
repositorysetting.Also contains some dependency fixes.
pyyaml >= 6.0.2so that it works with Cython 3+airflow.providers.cncf.kubernetes.operators.kubernetes_podtoairflow.providers.cncf.kubernetes.operators.podIssue ticket number and link
Closes #130
Checklist before requesting a review