add early error message if docker is missing #113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new method validate_installation(), which takes Commander instance as argument. For backends using Docker, it will be called at the begining of export() method. src/soopervisor: "airflow/export.py", "argo/export.py", "aws/batch.py" , "kubeflow/export.py" Add validate_installation() at the begining of export() method.
edublancas
requested changes
Sep 6, 2022
| Commander instance | ||
| """ | ||
|
|
||
| cmdr.run( |
There was a problem hiding this comment.
the user might now have awk installed, so this will fail. an easier way to check this is via shutil.which("docker")
|
closing due to inactivity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
src/soopervisor/commons: docker.py
Add new method
validate_installation(), which takesCommanderinstanceas argument.
For backends using Docker,
validate_installation()will be called at the begining ofexport()method.
src/soopervisor: airflow/export.py, argo/export.py, aws/batch.py
, kubeflow/export.py
Invoke
validate_installation()at the begining ofexport()method.Issue ticket number and link
Closes #72
Checklist before requesting a review