-
-
Notifications
You must be signed in to change notification settings - Fork 190
Updating scripts to match dash-core-components #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I personally hates prettier and do not want to see it here forced on users. I think the formatted code (with the dcc configs) is actually uglier, less readable (if you already have sane line length) and harder to refactor IMO (splitting lines makes them harder to move around with my IDE ctrl+shift selection). As for the publish script, what does it saves ? like one command line instead of three, I don't think it's that useful. Also, you don't have to publish on npm if you don't want to, so the script would have to be adapted to take that variable into consideration. The |
Like I said I agree that prettier shouldn't be forced (so perhaps we should remove the |
They don't need to be uploaded to NPM, I discovered that you only need to remove the So I added a |
Oh nice! In any case, it could still be useful to have a simple script that does |
Just linking to plotly/dash-core-components#299 (comment) where we discussed making the same improvements to these repo's too, in case that wasn't clear. Haven't had time to make those improvements yet, so future me if you're reading this, this is on you! |
But seriously if anyone else feels like picking this up, that would be great! |
We should update the scripts in
package.json
the same way as we did for dash-core-components. However, I don't think we should forceprettier
on the users, since some people are not a fan (although I noticed it's pretty much set up already in this repo, except there's noprettier
package inpackage.json
's dependencies. If we do want it, we could use theformat
andformat:test
scripts). We should copy over thepublish
script however, or perhaps add it to a scripts repo as mentioned in #17. We should also copy thebuild:watch
script, which rebuilds the bundle onsrc/
files changes, the'lint
andtest
scripts are also nice to have here.The text was updated successfully, but these errors were encountered: