Skip to content
This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Commit 341af3d

Browse files
jbamptonjbampton
committed
Clean up the CircleCI config file. Remove unneeded quotes from YAML keys.
Remove duplicate entry from .gitignore. Fix case of YAML value - Run.
1 parent 8bbe16e commit 341af3d

File tree

2 files changed

+35
-37
lines changed

2 files changed

+35
-37
lines changed

‎.circleci/config.yml‎

Lines changed: 35 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
version: 2
22

33
jobs:
4-
"server-test":
4+
server-test:
55
docker:
66
- image: circleci/python:3.7-node-browsers
77
- image: cypress/base:10
@@ -11,15 +11,15 @@ jobs:
1111
- restore_cache:
1212
key: dep-{{ .Branch }}-{{ checksum "package-lock.json" }}-{{ checksum "package.json" }}-{{ checksum ".circleci/config.yml" }}
1313
- run:
14-
name: Install npm packages
14+
name: 🏗️ Install npm packages
1515
command: npm ci
1616
- save_cache:
1717
key: dep-{{ .Branch }}-{{ checksum "package-lock.json" }}-{{ checksum "package.json" }}-{{ checksum ".circleci/config.yml" }}
1818
paths:
1919
- node_modules
2020

2121
- run:
22-
name: Install requirements
22+
name: 🏗️ Install requirements
2323
command: |
2424
sudo pip install --upgrade virtualenv
2525
python -m venv venv || virtualenv venv
@@ -30,7 +30,7 @@ jobs:
3030
cd dash-main/dash-renderer && npm run build && pip install -e . && cd ./../..
3131
3232
- run:
33-
name: Build
33+
name: 🏗️ Build
3434
command: |
3535
. venv/bin/activate
3636
npm run private::build:js-test
@@ -40,13 +40,13 @@ jobs:
4040
find . -name "*.gz" | xargs pip install --no-cache-dir --ignore-installed && cd ..
4141
4242
- run:
43-
name: Run tests
43+
name: 🧪 Run tests
4444
command: |
4545
. venv/bin/activate
4646
npm run test.server
4747
4848
49-
"standalone-test":
49+
standalone-test:
5050
docker:
5151
- image: circleci/python:3.6.7-node-browsers
5252
- image: cypress/base:10
@@ -56,10 +56,10 @@ jobs:
5656
- restore_cache:
5757
key: dep-{{ .Branch }}-{{ checksum "package-lock.json" }}-{{ checksum "package.json" }}-{{ checksum ".circleci/config.yml" }}
5858
- run:
59-
name: Install npm packages
59+
name: 🏗️ Install npm packages
6060
command: npm ci
6161
- run:
62-
name: Cypress Install
62+
name: 🏗️ Cypress Install
6363
command: |
6464
$(npm bin)/cypress install
6565
@@ -70,14 +70,14 @@ jobs:
7070
- /home/circleci/.cache/Cypress
7171

7272
- run:
73-
name: Run tests
73+
name: 🧪 Run tests
7474
command: |
7575
rm -rf node_modules/cypress
7676
npm i cypress@3.4.1
7777
npm run test.standalone
7878
7979
80-
"unit-test":
80+
unit-test:
8181
docker:
8282
- image: circleci/python:3.7.5-node-browsers
8383
- image: cypress/base:10
@@ -87,10 +87,10 @@ jobs:
8787
- restore_cache:
8888
key: dep-{{ .Branch }}-{{ checksum "package-lock.json" }}-{{ checksum "package.json" }}-{{ checksum ".circleci/config.yml" }}
8989
- run:
90-
name: Install npm packages
90+
name: 🏗️ Install npm packages
9191
command: npm ci
9292
- run:
93-
name: Cypress Install
93+
name: 🏗️ Cypress Install
9494
command: |
9595
$(npm bin)/cypress install
9696
@@ -101,7 +101,7 @@ jobs:
101101
- /home/circleci/.cache/Cypress
102102

103103
- run:
104-
name: Install requirements
104+
name: 🏗️ Install requirements
105105
command: |
106106
sudo pip install --upgrade virtualenv
107107
python -m venv venv || virtualenv venv
@@ -111,14 +111,14 @@ jobs:
111111
pip install -e ./dash-main[dev] --quiet
112112
113113
- run:
114-
name: Run tests
114+
name: 🧪 Run tests
115115
command: |
116116
. venv/bin/activate
117117
npm run build
118118
npm run test.unit
119119
120120
121-
"visual-test":
121+
visual-test:
122122
docker:
123123
- image: circleci/node:10-browsers
124124

@@ -129,7 +129,7 @@ jobs:
129129
key: dep-{{ .Branch }}-{{ checksum "package-lock.json" }}-{{ checksum "package.json" }}
130130

131131
- run:
132-
name: Install package.json
132+
name: 🏗️ Install package.json
133133
command: npm ci
134134

135135
- save_cache:
@@ -138,31 +138,31 @@ jobs:
138138
- node_modules
139139

140140
- run:
141-
name: Run build:js
141+
name: 🏗️ Run build:js
142142
command: npm run private::build:js
143143

144144
- run:
145-
name: Run visual tests
145+
name: 🧪 Run visual tests
146146
command: npm run test.visual
147147
- store_artifacts:
148148
path: storybook-static
149149

150-
"node":
150+
node:
151151
docker:
152152
- image: circleci/python:3.7.5-node
153153

154154
steps:
155155
- checkout
156156

157157
- run:
158-
name: Create virtual env
158+
name: 🔧 Create virtual env
159159
command: python -m venv || virtualenv venv
160160

161161
- restore_cache:
162162
key: dep-{{ .Branch }}-{{ checksum "package-lock.json" }}-{{ checksum "package.json" }}
163163

164164
- run:
165-
name: Install package.json
165+
name: 🏗️ Install package.json
166166
command: npm ci
167167

168168
- save_cache:
@@ -171,20 +171,20 @@ jobs:
171171
- node_modules
172172

173173
- run:
174-
name: Install requirements
174+
name: 🏗️ Install requirements
175175
command: |
176176
. venv/bin/activate
177177
pip install -r dev-requirements.txt --quiet
178178
179179
- run:
180-
name: Run eslint
180+
name: 🧪 Run eslint
181181
command: |
182182
. venv/bin/activate
183183
npm run lint
184184
when: always
185185

186186

187-
"python-3.6":
187+
python-3.6:
188188
docker:
189189
- image: circleci/python:3.7.5-stretch-node-browsers
190190

@@ -196,12 +196,12 @@ jobs:
196196
- checkout
197197

198198
- run:
199-
name: Inject Percy Environment variables
199+
name: 💉 Inject Percy Environment variables
200200
command: |
201201
echo 'export PERCY_TOKEN="$PERCY_PYTHON_TOKEN_V0"' >> $BASH_ENV
202202
203203
- run:
204-
name: Install requirements
204+
name: 🏗️ Install requirements
205205
command: |
206206
sudo pip install --upgrade virtualenv
207207
python -m venv venv || virtualenv venv
@@ -210,15 +210,15 @@ jobs:
210210
npm ci
211211
212212
- run:
213-
name: Install dependencies (dash)
213+
name: 🏗️ Install dependencies (dash)
214214
command: |
215215
. venv/bin/activate
216216
git clone --depth 1 git@github.com:plotly/dash.git dash-main
217217
pip install -e ./dash-main[dev,testing] --quiet
218218
cd dash-main/dash-renderer && npm run build && pip install -e . && cd ../..
219219
220220
- run:
221-
name: Install test requirements
221+
name: 🏗️ Install test requirements
222222
command: |
223223
. venv/bin/activate
224224
npm run build
@@ -227,7 +227,7 @@ jobs:
227227
find . -name "*.gz" | xargs pip install --no-cache-dir --ignore-installed && cd ..
228228
229229
- run:
230-
name: ⚙️ run integration test
230+
name: ⚙️ Run integration test
231231
command: |
232232
. venv/bin/activate
233233
pytest --junitxml=test-reports/dash.xml tests/integration
@@ -244,9 +244,9 @@ workflows:
244244
version: 2
245245
build:
246246
jobs:
247-
- "python-3.6"
248-
- "node"
249-
- "server-test"
250-
- "standalone-test"
251-
- "unit-test"
252-
- "visual-test"
247+
- python-3.6
248+
- node
249+
- server-test
250+
- standalone-test
251+
- unit-test
252+
- visual-test

‎.gitignore‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,5 +42,3 @@ lib
4242
dist
4343
*__pycache__*
4444
__pycache__/
45-
46-
*.pyc

0 commit comments

Comments
 (0)