Skip to content

Commit 6d43b21

Browse files
committed
Refactor enable_dev_tools variables names.
1 parent 672dd3a commit 6d43b21

File tree

1 file changed

+26
-24
lines changed

1 file changed

+26
-24
lines changed

dash/dash.py

Lines changed: 26 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,9 @@ def add_url(name, view_func, methods=('GET',)):
217217
self._layout = None
218218
self._cached_layout = None
219219
self.routes = []
220-
self._serve_dev_bundle = False
220+
self._dev_tools = _AttributeDict({
221+
'serve_dev_bundles': False
222+
})
221223

222224
@property
223225
def layout(self):
@@ -360,13 +362,13 @@ def _generate_scripts_html(self):
360362
srcs = self._collect_and_register_resources(
361363
self.scripts._resources._filter_resources(
362364
dash_renderer._js_dist_dependencies,
363-
dev_bundles=self._serve_dev_bundle
365+
dev_bundles=self._dev_tools.serve_dev_bundles
364366
)) + self._external_scripts + self._collect_and_register_resources(
365367
self.scripts.get_all_scripts(
366-
dev_bundles=self._serve_dev_bundle) +
368+
dev_bundles=self._dev_tools.serve_dev_bundles) +
367369
self.scripts._resources._filter_resources(
368370
dash_renderer._js_dist,
369-
dev_bundles=self._serve_dev_bundle
371+
dev_bundles=self._dev_tools.serve_dev_bundles
370372
))
371373

372374
return '\n'.join([
@@ -959,46 +961,46 @@ def get_asset_url(self, path):
959961

960962
return asset
961963

962-
def activate_dev_tools(self,
963-
dev_tools=True,
964-
dev_tools_bundles=True):
964+
def enable_dev_tools(self,
965+
debug=False,
966+
dev_tools_serve_bundles=None):
965967
"""
966968
Activate the dev tools, called by `run_server`. If your application is
967969
served by wsgi and you want to activate the dev tools, you can call
968970
this method out of `__main__`.
969971
970-
:param dev_tools: If false no tools will be activated.
971-
:type dev_tools: bool
972-
:param dev_tools_bundles: Serve the dev bundles of component libs.
973-
:type dev_tools_bundles: bool
972+
:param debug: If false no tools will be activated.
973+
:type debug: bool
974+
:param dev_tools_serve_bundles: Serve the dev bundles of component libs.
975+
:type dev_tools_serve_bundles: bool
974976
:return:
975977
"""
976-
if not dev_tools:
978+
if not debug:
977979
return
978-
self._serve_dev_bundle = dev_tools_bundles
980+
981+
env = _configs.env_configs()
982+
983+
self._dev_tools['serve_dev_bundles'] = _configs.get_config(
984+
'serve_dev_bundles', dev_tools_serve_bundles, env, True)
979985

980986
def run_server(self,
981987
port=8050,
982988
debug=False,
983-
dev_tools=True,
984-
dev_tools_bundles=True,
989+
dev_tools_serve_dev_bundles=None,
985990
**flask_run_options):
986991
"""
987992
Start the flask server in local mode, you should not run this on a
988-
production server and use gunicorn/waitress instead. By default will
989-
activate the dev tools (dev bundles).
993+
production server and use gunicorn/waitress instead.
990994
991995
:param port: Port the application
992996
:type port: int
993-
:param debug: Set the debug mode of flask.
997+
:param debug: Set the debug mode of flask and enable the dev tools.
994998
:type debug: bool
995-
:param dev_tools: Activate all the dev tools.
996-
:type dev_tools: bool
997-
:param dev_tools_bundles: Serve the dev bundles of component libs.
998-
:type dev_tools_bundles: bool
999+
:param dev_tools_serve_dev_bundles: Serve the dev bundles of component libs.
1000+
:type dev_tools_serve_dev_bundles: bool
9991001
:param flask_run_options: Given to `Flask.run`
10001002
:return:
10011003
"""
1002-
self.activate_dev_tools(dev_tools, dev_tools_bundles)
1003-
self.server.run(port=port, debug=dev_tools or debug,
1004+
self.enable_dev_tools(debug, dev_tools_serve_dev_bundles)
1005+
self.server.run(port=port, debug=debug,
10041006
**flask_run_options)

0 commit comments

Comments
 (0)