Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in missing events/inputs error #485

Merged
merged 2 commits into from
Dec 10, 2018
Merged

Fix typo in missing events/inputs error #485

merged 2 commits into from
Dec 10, 2018

Conversation

mungojam
Copy link
Contributor

@mungojam mungojam commented Dec 8, 2018

whenever vs. whenver

@T4rk1n
Copy link
Contributor

T4rk1n commented Dec 9, 2018

💃 Can you update the version and changelog ? I'll merge/release once done.

@mungojam
Copy link
Contributor Author

mungojam commented Dec 9, 2018 •
edited
Loading

I've just checked the contributing guide and wonder if I've applied the correct versioning and steps (looks like I haven't). Hopefully you're happy to take it as is

@T4rk1n
Copy link
Contributor

T4rk1n commented Dec 10, 2018

Perfect, thanks.

@T4rk1n T4rk1n merged commit 75a285f into plotly:master Dec 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mungojam @T4rk1n