partial insiderange support is out of scope at this point

Author: archmoj

Diff for: src/plots/cartesian/range_defaults.js

@@ -14,7 +14,18 @@ module.exports = function handleRangeDefaults(containerIn, containerOut, coerce,
         var insiderange;
         if(!options.noInsiderange && axType !== 'log') {
             insiderange = coerce('insiderange');
-            range = coerce('range', insiderange);
+
+            // We may support partial insideranges in future
+            // For now it is out of scope
+            if(insiderange && (
+                    insiderange[0] === null ||
+                    insiderange[1] === null
+            )) {
+                containerOut.insiderange = false;
+                insiderange = undefined;
+            }
+
+            if(insiderange) range = coerce('range', insiderange);
         }
     }
 

Diff for: test/image/baselines/zz-insiderange-x-partial.png

@@ -1047,85 +1047,29 @@ describe('Test click interactions:', function() {
             .then(done, done.fail);
         });
 
-        it('when set to \'reset+autorange\' (the default) should autosize on 1st and 2nd double clicks (*min* partial insiderange and inside tick lables)', function(done) {
+        it('when set to \'reset+autorange\' (the default) should autosize on 1st and 2nd double clicks (insiderange and inside tick lables)', function(done) {
             mockCopy = setRanges(mockCopy);
 
             Plotly.newPlot(gd, [{
-                y: [1, 3, 2]}
+                y: [0, 1, 2, 3]}
             ], {
-                xaxis: {insiderange: [null, 1]},
-                yaxis: {ticks: 'inside', ticklabelposition: 'inside'},
-                plot_bgcolor: 'lightgray',
-                width: 600,
-                height: 600
-            }).then(function() {
-                expect(gd.layout.xaxis.range).toBeCloseToArray([-0.166, 1]);
-
-                return doubleClick(300, 300);
-            })
-            .then(function() {
-                expect(gd.layout.xaxis.range).toBeCloseToArray([-0.166, 2.134]);
-
-                return doubleClick(300, 300);
-            })
-            .then(function() {
-                expect(gd.layout.xaxis.range).toBeCloseToArray([-0.166, 1]);
-            })
-            .then(done, done.fail);
-        });
-
-        it('when set to \'reset+autorange\' (the default) should autosize on 1st and 2nd double clicks (*max* partial insiderange and inside tick lables)', function(done) {
-            mockCopy = setRanges(mockCopy);
-
-            Plotly.newPlot(gd, [{
-                y: [2, 3, 1]}
-            ], {
-                xaxis: {insiderange: [1, null]},
+                xaxis: {insiderange: [1, 2]},
                 yaxis: {ticks: 'inside', ticklabelposition: 'inside', side: 'right'},
                 plot_bgcolor: 'lightgray',
                 width: 600,
                 height: 600
             }).then(function() {
-                expect(gd.layout.xaxis.range).toBeCloseToArray([1, 2.166]);
-
-                return doubleClick(300, 300);
-            })
-            .then(function() {
-                expect(gd.layout.xaxis.range).toBeCloseToArray([-0.134, 2.166]);
-
-                return doubleClick(300, 300);
-            })
-            .then(function() {
-                expect(gd.layout.xaxis.range).toBeCloseToArray([1, 2.166]);
-            })
-            .then(done, done.fail);
-        });
-
-        it('when set to \'reset+autorange\' (the default) should autosize on 1st and 2nd double clicks (case of partial ranges reversed)', function(done) {
-            mockCopy = setRanges(mockCopy);
-
-            Plotly.newPlot(gd, [{
-                y: [1, 2, 3, 4]}
-            ], {
-                xaxis: {range: [null, 1], autorange: 'max reversed'},
-                yaxis: {range: [3, null], autorange: 'min reversed'},
-                width: 600,
-                height: 600
-            }).then(function() {
-                expect(gd.layout.xaxis.range).toBeCloseToArray([3.2, 1]);
-                expect(gd.layout.yaxis.range).toBeCloseToArray([3, 0.8]);
+                expect(gd.layout.xaxis.range).toBeCloseToArray([1, 2.068]);
 
                 return doubleClick(300, 300);
             })
             .then(function() {
-                expect(gd.layout.xaxis.range).toBeCloseToArray([3.2, -0.2]);
-                expect(gd.layout.yaxis.range).toBeCloseToArray([4.2, 0.8]);
+                expect(gd.layout.xaxis.range).toBeCloseToArray([-0.2019, 3.249]);
 
                 return doubleClick(300, 300);
             })
             .then(function() {
-                expect(gd.layout.xaxis.range).toBeCloseToArray([3.2, 1]);
-                expect(gd.layout.yaxis.range).toBeCloseToArray([3, 0.8]);
+                expect(gd.layout.xaxis.range).toBeCloseToArray([1, 2.068]);
             })
             .then(done, done.fail);
         });