push trace module into fullLayout._modules even if visible:false

- so that gl-based trace can call their plot methods w/ an empty array of traces and just work. - this makes restyle(gd, 'visible', false) work properly for scattergl traces
plotly · Jul 23, 2018 · 3790734 · etpinard · Jul 23, 2018 · 3790734
1 parent 1675047
commit 3790734
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/plots/plots.js b/src/plots/plots.js
@@ -696,7 +696,7 @@ plots._hasPlotType = function(category) {
         if(basePlotModules[i].name === category) return true;
     }
 
-    // check trace modules
+    // check trace modules (including non-visible:true)
     var modules = this._modules || [];
     for(i = 0; i < modules.length; i++) {
         var name = modules[i].name;
@@ -912,7 +912,7 @@ plots.supplyDataDefaults = function(dataIn, dataOut, layout, fullLayout) {
         var _module = fullTrace._module;
         if(!_module) return;
 
-        if(fullTrace.visible === true) Lib.pushUnique(modules, _module);
+        Lib.pushUnique(modules, _module);
 // call Scattergl.plot separately 
 if(fullLayout._has('scattergl')) { 
     _module = Registry.getModule('scattergl'); 
     cdModule = getModuleCalcData(cdSubplot, _module)[0]; 
     _module.plot(gd, plotinfo, cdModule); 
 } 
 var hadGl = (oldFullLayout._has && oldFullLayout._has('gl')); 
 var hasGl = (newFullLayout._has && newFullLayout._has('gl')); 
 if(hadGl && !hasGl) { 
     for(k in oldPlots) { 
         plotinfo = oldPlots[k]; 
         if(plotinfo._scene) plotinfo._scene.destroy(); 
     } 
 } 
 // call Scattergl.plot separately 
 if(fullLayout._has('scattergl')) { 
     _module = Registry.getModule('scattergl'); 
     cdModule = getModuleCalcData(cdSubplot, _module)[0]; 
     _module.plot(gd, plotinfo, cdModule); 
 } 
 var hadGl = (oldFullLayout._has && oldFullLayout._has('gl')); 
 var hasGl = (newFullLayout._has && newFullLayout._has('gl')); 
  
 if(hadGl && !hasGl) { 
     for(k in oldPlots) { 
         plotinfo = oldPlots[k]; 
         if(plotinfo._scene) plotinfo._scene.destroy(); 
     } 
 } 
         Lib.pushUnique(basePlotModules, fullTrace._module.basePlotModule);
 
         cnt++;