some wip comments

Author: etpinard

Diff for: src/lib/index.js

@@ -405,6 +405,7 @@ lib.syncOrAsync = function(sequence, arg, finalStep) {
         fni = sequence.splice(0, 1)[0];
         ret = fni(arg);
 
+        // TODO https://github.com/plotly/plotly.js/issues/1705
         if(ret && ret.then) {
             return ret.then(continueAsync)
                 .then(undefined, lib.promiseError);

Diff for: src/plot_api/plot_api.js

@@ -319,6 +319,9 @@ function plot(gd, data, layout, config) {
         ], gd);
     }
 
+    // potential TODO
+    // - merge with positionAndAutorange ?
+    // - rename positionAndAutorange (as we no longer call _module.setPositions here)
     function doAutoRangeAndConstraints() {
         if(gd._transitioning) return;
 

Diff for: src/plot_api/subroutines.js

@@ -50,6 +50,8 @@ function overlappingDomain(xDomain, yDomain, domains) {
     return false;
 }
 
+// TODO
+// - split general pieces from Cartesian-only
 function lsInner(gd) {
     var fullLayout = gd._fullLayout;
     var gs = fullLayout._size;
@@ -72,6 +74,7 @@ function lsInner(gd) {
     // can still get here because it makes some of the SVG structure
     // for shared features like selections.
     if(!fullLayout._has('cartesian')) {
+        // TODO why not Plots.previousPromises ??
         return gd._promises.length && Promise.all(gd._promises);
     }
 
@@ -347,6 +350,7 @@ function lsInner(gd) {
 
     Axes.makeClipPaths(gd);
 
+    // TODO why not Plots.previousPromises ??
     return gd._promises.length && Promise.all(gd._promises);
 }
 
@@ -738,3 +742,41 @@ exports.drawMarginPushers = function(gd) {
     Registry.getComponentMethod('updatemenus', 'draw')(gd);
     Registry.getComponentMethod('colorbar', 'draw')(gd);
 };
+
+exports.prerender = function(gd) {
+    Axes.prerender(gd);
+    Registry.getComponentMethod('legend', 'prerender')(gd);
+    Registry.getComponentMethod('colorbar', 'prerender')(gd);
+    Registry.getComponentMethod('updatemenus', 'prerender')(gd);
+    Registry.getComponentMethod('sliders', 'prerender')(gd);
+    Registry.getComponentMethod('rangeselector', 'prerender')(gd);
+    return Plots.previousPromises(gd);
+};
+
+exports.marginPushers = function(gd) {
+    Plots.clearAutoMarginIds(gd);
+    Axes.allowAutoMargin(gd);
+
+    Axes.pushMargin(gd);
+    Registry.getComponentMethod('legend', 'pushMargin')(gd);
+    Registry.getComponentMethod('colorbar', 'pushMargin')(gd);
+    Registry.getComponentMethod('updatemenus', 'pushMargin')(gd);
+    Registry.getComponentMethod('sliders', 'pushMargin')(gd);
+    Registry.getComponentMethod('rangeselector', 'pushMargin')(gd);
+    Plots.doAutoMargin(gd);
+};
+
+exports.drawComponents = function(gd) {
+    Registry.getComponentMethod('shapes', 'draw')(gd);
+    Registry.getComponentMethod('images', 'draw')(gd);
+    Registry.getComponentMethod('annotations', 'draw')(gd);
+
+    Registry.getComponentMethod('rangeselector', 'draw')(gd);
+    Registry.getComponentMethod('rangeslider', 'draw')(gd);
+
+    Registry.getComponentMethod('legend', 'draw')(gd);
+    Registry.getComponentMethod('colorbar', 'draw')(gd);
+
+    Registry.getComponentMethod('sliders', 'draw')(gd);
+    Registry.getComponentMethod('updatemenus', 'draw')(gd);
+};