_commonLength -> _length

so aggregations and other common routines only have to look at _length

Author: alexcjohnson

src/plots/cartesian/type_defaults.js

@@ -107,7 +107,7 @@ function getFirstNonEmptyTrace(data, id, axLetter) {
         var trace = data[i];
 
         if(trace.type === 'splom' &&
-                trace._commonLength > 0 &&
+                trace._length > 0 &&
                 trace['_' + axLetter + 'axes'][id]
         ) {
             return trace;

src/traces/parcoords/calc.js

@@ -15,7 +15,7 @@ var wrap = require('../../lib/gup').wrap;
 
 module.exports = function calc(gd, trace) {
     var cs = !!trace.line.colorscale && Lib.isArrayOrTypedArray(trace.line.color);
-    var color = cs ? trace.line.color : constHalf(trace._commonLength);
+    var color = cs ? trace.line.color : constHalf(trace._length);
     var cscale = cs ? trace.line.colorscale : [[0, trace.line.color], [1, trace.line.color]];
 
     if(hasColorscale(trace, 'line')) {

src/traces/parcoords/defaults.js

@@ -26,7 +26,7 @@ function handleLineDefaults(traceIn, traceOut, defaultColor, layout, coerce) {
             // TODO: I think it would be better to keep showing lines beyond the last line color
             // but I'm not sure what color to give these lines - probably black or white
             // depending on the background color?
-            traceOut._commonLength = Math.min(traceOut._commonLength, lineColor.length);
+            traceOut._length = Math.min(traceOut._length, lineColor.length);
         }
         else {
             traceOut.line.color = defaultColor;
@@ -84,7 +84,7 @@ function dimensionsDefaults(traceIn, traceOut) {
         dimensionsOut.push(dimensionOut);
     }
 
-    traceOut._commonLength = commonLength;
+    traceOut._length = commonLength;
 
     return dimensionsOut;
 }
@@ -108,7 +108,7 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
     // but we can't do this in dimensionsDefaults (yet?) because line.color can also
     // truncate
     for(var i = 0; i < dimensions.length; i++) {
-        if(dimensions[i].visible) dimensions[i]._length = traceOut._commonLength;
+        if(dimensions[i].visible) dimensions[i]._length = traceOut._length;
     }
 
     // make default font size 10px (default is 12),

src/traces/parcoords/parcoords.js

@@ -142,7 +142,7 @@ function model(layout, d, i) {
         color: lineColor.map(d3.scale.linear().domain(dimensionExtent({
             values: lineColor,
             range: [line.cmin, line.cmax],
-            _length: trace._commonLength
+            _length: trace._length
         }))),
         blockLineCount: c.blockLineCount,
         canvasOverdrag: c.overdrag * c.canvasPixelRatio

src/traces/scattergl/convert.js

@@ -87,7 +87,7 @@ function convertStyle(gd, trace) {
 }
 
 function convertMarkerStyle(trace) {
-    var count = trace._length || trace._commonLength;
+    var count = trace._length;
     var optsIn = trace.marker;
     var optsOut = {};
     var i;

src/traces/splom/defaults.js

@@ -86,7 +86,7 @@ function handleDimensionsDefaults(traceIn, traceOut) {
         if(dimOut.visible) dimOut._length = commonLength;
     }
 
-    traceOut._commonLength = commonLength;
+    traceOut._length = commonLength;
 
     return dimensionsOut.length;
 }

src/traces/splom/index.js

@@ -29,7 +29,7 @@ var TOO_MANY_POINTS = require('../scattergl/constants').TOO_MANY_POINTS;
 
 function calc(gd, trace) {
     var dimensions = trace.dimensions;
-    var commonLength = trace._commonLength;
+    var commonLength = trace._length;
     var stash = {};
     var opts = {};
     // 'c' for calculated, 'l' for linear,
@@ -228,7 +228,7 @@ function plotOne(gd, cd0) {
     scene.unselectBatch = null;
 
     if(selectMode) {
-        var commonLength = trace._commonLength;
+        var commonLength = trace._length;
 
         if(!scene.selectBatch) {
             scene.selectBatch = [];

test/jasmine/tests/parcoords_test.js

@@ -182,7 +182,7 @@ describe('parcoords initialization tests', function() {
                 {values: [], visible: true},
                 {values: [1, 2], visible: false} // shouldn't be truncated to as visible: false
             ]});
-            expect(fullTrace._commonLength).toBe(3);
+            expect(fullTrace._length).toBe(3);
         });
 
         it('cleans up constraintrange', function() {

test/jasmine/tests/splom_test.js

@@ -82,7 +82,7 @@ describe('Test splom trace defaults:', function() {
         });
 
         var fullTrace = gd._fullData[0];
-        expect(fullTrace._commonLength).toBe(3, 'common length');
+        expect(fullTrace._length).toBe(3, 'common length');
         expect(fullTrace.dimensions[0]._length).toBe(3, 'dim 0 length');
         expect(fullTrace.dimensions[1]._length).toBe(3, 'dim 1 length');
         expect(fullTrace.xaxes).toEqual(['x', 'x2']);