Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: GL2D scatterplot marker size and redrawing/restyling breaks plot #1510

Closed
destradafilm opened this issue Mar 22, 2017 · 5 comments · Fixed by gl-vis/gl-scatter2d-sdf#1 or #1521
Closed
Labels
bug something broken

Comments

@destradafilm
Copy link

destradafilm commented Mar 22, 2017

In this example, I'm using the LATEST version of plotly https://cdn.plot.ly/plotly-latest.min.js I change the size of the marker to an array. Some Markers should get bigger and some should get smaller. The result is that they move in x and y coordinates and get slightly smaller. Unless, I change the symbol of the marker. The 'redraw' or 'restyle' function cleans it up

EXAMPLE:
latest version of plotly bug

CODEPEN:
http://codepen.io/destrada/pen/xqYJYQ


When I switch to version 1.5.0 https://cdn.plot.ly/plotly-1.5.0.min.js of Plotly, it responds correctly to resizing the Markers and redrawing

EXAMPLE:
version 1 5 doesn t break marker size

CODEPEN:
http://codepen.io/destrada/pen/mWLRzZ

@destradafilm destradafilm changed the title BUG: Changing WebGL scatterplot marker size and redrawing/restyling breaks plot BUG: GL2D scatterplot marker size and redrawing/restyling breaks plot Mar 22, 2017
@etpinard
Copy link
Contributor

Ok. Interesting. Have you tried using restyle instead of the soon to be deprecated redraw?

@destradafilm
Copy link
Author

I updated the codepens by switching it to restyle instead of redraw and it has the same results

@etpinard
Copy link
Contributor

Thanks for the report!

This probably a side-effect of @dfcreative 's #1398

@dy
Copy link
Contributor

dy commented Mar 24, 2017

Oh, yes, that might be. Gotta check in details.

@dy
Copy link
Contributor

dy commented Mar 24, 2017

gl-scatter2d-sdf@1.3.4 fixes that.

@etpinard etpinard added the bug something broken label Mar 24, 2017
@etpinard etpinard added this to the v1.26.0 milestone Mar 24, 2017
@etpinard etpinard removed this from the v1.26.0 milestone Mar 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
3 participants