The typed array polyfill we provide in dist/ does not polyfill ArrayBuffer.isView

[etpinard]

First reported in plotly/plotly.R#1055

In our src code, we add a fallback to ArrayBuffer.isView here, but @dfcreative 's color-parse does not. This lead to 3D and gl2d (and anything else using color-rgba) breaking in RStudio even with typed array polyfill we provide in dist/.

So, we could of course patch color-parse to include an isView fallback, this will fix this one case. But maybe instead we could add a ArrayBuffer.isView polyfill to the typedarray.min.js we provide which will solve this problem for all our dependencies.

By the way, does anyone know where typedarray.min.js comes from?

cc @alexcjohnson @cpsievert @bcdunbar

[dy]

@etpinard I can just check if ArrayBuffer has that method.

[etpinard]

@etpinard I can just check if ArrayBuffer has that method.

Yeah, that would be great thanks 👍

[dy]

@etpinard done colorjs/color-parse@4be59c5#diff-168726dbe96b3ce427e7fedce31bb0bcL164

[etpinard]

Thanks @dfcreative I'll include your fix in the next patch release 1.29.1 (probably coming next Monday).

[etpinard]

Oops. I forgot to include this in 1.29.1. My mistake.

[etpinard]

@dfcreative would you mind publishing colorjs/color-parse@4be59c5#diff-168726dbe96b3ce427e7fedce31bb0bcL164 and making a PR here bumping color-rgba?

[dy]

@etpinard here #1915

[etpinard]

fixed by #1915 (verification made by @cpsievert )

[etpinard]

Actually, I'll reopen this issue.

#1915 fixed the issue, but the typed array polyfill we provide in dist/ does not polyfill ArrayBuffer.isView still holds.

[jackparmer]

This issue has been tagged with NEEDS SPON$OR

A community PR for this feature would certainly be welcome, but our experience is deeper features like this are difficult to complete without the Plotly maintainers leading the effort.

What Sponsorship includes:

• Completion of this feature to the Sponsor's satisfaction, in a manner coherent with the rest of the Plotly.js library and API
• Tests for this feature
• Long-term support (continued support of this feature in the latest version of Plotly.js)
• Documentation at plotly.com/javascript
• Possibility of integrating this feature with Plotly Graphing Libraries (Python, R, F#, Julia, MATLAB, etc)
• Possibility of integrating this feature with Dash
• Feature announcement on community.plotly.com with shout out to Sponsor (or can remain anonymous)
• Gratification of advancing the world's most downloaded, interactive scientific graphing libraries (>50M downloads across supported languages)

Please include the link to this issue when contacting us to discuss.

[gvwilson]

Hi - this issue has been sitting for a while, so as part of our effort to tidy up our public repositories I'm going to close it. If it's still a concern, we'd be grateful if you could open a new issue (with a short reproducible example if appropriate) so that we can add it to our stack. Cheers - @gvwilson