Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marshal _indexToPoints to interaction events; other additions #2128

Closed
2 of 3 tasks
monfera opened this issue Oct 27, 2017 · 3 comments
Closed
2 of 3 tasks

Marshal _indexToPoints to interaction events; other additions #2128

monfera opened this issue Oct 27, 2017 · 3 comments

Comments

@monfera
Copy link
Contributor

monfera commented Oct 27, 2017

We have added logic to transforms such that the ultimate results of transforms can be associated with the original data points, via their positional indices. This way, interacting with e.g. an aggregate bar, the original points can be known, which is crucial for crossfilter to work, among other possible uses.

The linked PR took care of the logic but exposing it via events is a useful next step: #2126 (review)

Besides this, other changes are needed:

  • cover groupByand sort transforms as well (groupBy is not currently working with crossfilter, so it was less of a priority) done in More indexToPoints  #2162
  • extract the few lines that are identical between the filter.js and aggregation.js implementations
  • add more test cases with various transforms sequences
@monfera
Copy link
Contributor Author

monfera commented Oct 27, 2017

Regarding the implementation, how @alexcjohnson proposes it above seems to be the best way.

@etpinard
Copy link
Contributor

Resolving this would fix #1807 I believe.

@etpinard etpinard added the feature something new label Oct 27, 2017
@etpinard
Copy link
Contributor

as only item

add more test cases with various transforms sequences

is left, changing the label from feature to maintenance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants