Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update es.js #2268

Merged
merged 1 commit into from
Jan 19, 2018
Merged

Update es.js #2268

merged 1 commit into from
Jan 19, 2018

Conversation

n-riesco
Copy link
Contributor

  • Added translation for Click to enter radial axis title
  • Added translation for new text

* Added translation for `Click to enter radial axis title`
* Added translation for `new text`
@@ -21,6 +21,7 @@ module.exports = {
'Click to enter Plot title': 'Introducir el título de la Gráfica', // plot_api/plot_api.js:579
'Click to enter X axis title': 'Introducir el título del eje X', // plots/plots.js:301
'Click to enter Y axis title': 'Introducir el título del eje Y', // plots/plots.js:302
'Click to enter radial axis title': 'Introducir el título del eje radial',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nit-picking: here I've translated the original radial axis, but I think polar axis is more common.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't polar axis ambiguous between angular and radial? Anyway that's a separate discussion, within the existing context this looks great, thanks!

Copy link
Contributor Author

@n-riesco n-riesco Jan 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I've just realised that radial axis here is not the actual axis (i.e. the polar axis used as a reference to measure the angular coordinate).

Is there a string to translate for the "angular axis"?
No, there isn't.

@@ -60,6 +61,7 @@ module.exports = {
'mean:': 'media:', // traces/box/calc.js:133
'median:': 'mediana:', // traces/box/calc.js:128
'min:': 'mín:', // traces/box/calc.js:129
'new text': 'nuevo texto',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammatically, the translation should be texto nuevo (as is insertar un texto nuevo), but in software nuevo texto is more common (I guess this is the result of the influence of the original English).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Insidious, isn't it 😈

Thanks @n-riesco , I'll merge once I get tests to pass; the new regl code is awesome but it's wreaking havoc on CI right now...

@alexcjohnson alexcjohnson merged commit bb79fda into plotly:master Jan 19, 2018
@alexcjohnson
Copy link
Collaborator

cc @JonasGutermuth @jdugge - at some point we'll need a more formal process for communicating new translation keys, but for now since we only have a few languages this'll do. Care to translate "Click to enter radial axis title" (new with polar 2.0 #2200) and "new text" (for blank annotations, I missed this in my initial string wrapping push) to German?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants