Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the title side for odd cheaterslope situations #2285

Merged
merged 2 commits into from
Jan 24, 2018
Merged

Conversation

alexcjohnson
Copy link
Collaborator

Fixes #2254

The mock I added here really highlights the fact that we don't explicitly include labels/titles in autoranging the containing axes for carpets... but that's outside the scope of this fix. Actually, this mock isn't even autoranged, or you wouldn't be able to see some of the titles at all! Mostly though this is only a problem for tiny carpets as used in these mocks, most real-world examples are just fine.

Anyway, before the fix this mock would have looked kind of like:

cheaterslope before fix

Ie some of the titles are just completely in the wrong locations.

@bpostlethwaite please review - I would like to get this fixed before we make a slider for cheaterslope that makes it super easy to access these conditions 😅

@alexcjohnson
Copy link
Collaborator Author

ah shoot, the failing airfoil mock pointed out that this doesn't work with showticklabels: 'none' - hold on, a little more work to do...

@alexcjohnson
Copy link
Collaborator Author

@bpostlethwaite ready for review

@bpostlethwaite
Copy link
Member

Good catch - 💃
Is there an issue for implementing the full autoranging behaviour for carpet axes titles/labels?

@alexcjohnson
Copy link
Collaborator Author

Is there an issue for implementing the full autoranging behaviour for carpet axes titles/labels?

Good point, no, but now there is -> #2289

@alexcjohnson alexcjohnson merged commit a775325 into master Jan 24, 2018
@alexcjohnson alexcjohnson deleted the carpet-title branch January 24, 2018 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

carpet plot a/b axis title positioning bug
2 participants