fix the title side for odd cheaterslope situations #2285
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2254
The mock I added here really highlights the fact that we don't explicitly include labels/titles in autoranging the containing axes for carpets... but that's outside the scope of this fix. Actually, this mock isn't even autoranged, or you wouldn't be able to see some of the titles at all! Mostly though this is only a problem for tiny carpets as used in these mocks, most real-world examples are just fine.
Anyway, before the fix this mock would have looked kind of like:
Ie some of the titles are just completely in the wrong locations.
@bpostlethwaite please review - I would like to get this fixed before we make a slider for
cheaterslope
that makes it super easy to access these conditions 😅