Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gl3d hover not working on mobile and tablet since v1.34.0 #4550

Closed
archmoj opened this issue Feb 4, 2020 · 6 comments · Fixed by #5239
Closed

Gl3d hover not working on mobile and tablet since v1.34.0 #4550

archmoj opened this issue Feb 4, 2020 · 6 comments · Fixed by #5239
Labels
bug something broken regression this used to work

Comments

@archmoj
Copy link
Contributor

archmoj commented Feb 4, 2020

Since v1.34.0 the gl3d hover not working on mobile and tablet devices
working demo using 1.33.x

@archmoj archmoj added bug something broken regression this used to work labels Feb 4, 2020
@archmoj archmoj self-assigned this Feb 4, 2020
@archmoj
Copy link
Contributor Author

archmoj commented Feb 4, 2020

Possibly related to #2296.

@archmoj archmoj removed their assignment Mar 3, 2020
@jdpaterson
Copy link
Contributor

I would like to get this fixed. I think the commit where this stopped working is this one: 7221cd0

In camera.js if I change the 3 lines that say:
supportsPassive ? {passive: false} : false
to be
supportsPassive ? {passive: true} : false
then it works again.

@archmoj
Copy link
Contributor Author

archmoj commented Oct 28, 2020

I would like to get this fixed. I think the commit where this stopped working is this one: 7221cd0

In camera.js if I change the 3 lines that say:
supportsPassive ? {passive: false} : false
to be
supportsPassive ? {passive: true} : false
then it works again.

@jdpaterson Would you interested to submit a PR?

@jdpaterson
Copy link
Contributor

@archmoj I am would like to, but the file I mentioned above, "plots/gl3d/camera.js" doesn't exist anymore, it seems the logic has been moved elsewhere. Do we know where that logic might have been moved to? I'll keep looking

@archmoj
Copy link
Contributor Author

archmoj commented Oct 28, 2020

@archmoj I am would like to, but the file I mentioned above, "plots/gl3d/camera.js" doesn't exist anymore, it seems the logic has been moved elsewhere. Do we know where that logic might have been moved to? I'll keep looking

It is in gl-plot3d dependency: https://github.com/gl-vis/gl-plot3d/blob/master/camera.js

@jdpaterson
Copy link
Contributor

Ok I'll make a PR there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken regression this used to work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants